Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Upgrade UI dependencies #384

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

chore(ui): Upgrade UI dependencies #384

wants to merge 23 commits into from

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented Jun 28, 2024

Context

Similar to what had been done in MLP caraml-dev/mlp#100 and in Merlin caraml-dev/merlin#591, this PR updates certain UI dependencies in Turing, most notably:

  • node.js from v16 to v20 (an engines.node field is added in the package.json file to pin the engine to >=20.13.1)
  • react from v17 to v18
  • elastic UI from v66 to v95.2.0

Other minor changes have also been made to the GitHub CICD files (more details are covered below and in the comments left on the diff itself).

Main Changes

  • Upgrading of UI dependencies
  • Removal of the unused GitHub workflow to release the Turing Helm chart (this chart has already been moved to the caraml-dev/helm-charts repo a long time ago)
  • Upgrading of multiple GitHub actions; see the subsection below for more information

GitHub Actions Updates

  • actions/upload-artifact - from v2 to v4 since the former has already been deprecated since the 30th of June this year
  • actions/download-artifact - from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action and upload-artifact need to be compatible to work)
  • actions/checkout - from v3 to v4 since it's similarly done in the MLP repo
  • actions/setup-go - from v4 to v5 since it's similarly done in the MLP repo (also provides caching)
  • actions/setup-python - from v2 to v5 to keep it updated to the latest version (also provides caching)
  • docker/login-action - from v1 to v3 just to keep it updated to the latest version
  • jupyterhub/action-k8s-await-workloads - from v1 to v3 just to keep it updated to the latest version

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (4f1cbd2) to head (51a67f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   62.27%   68.07%   +5.79%     
==========================================
  Files         124      149      +25     
  Lines        9774    11809    +2035     
==========================================
+ Hits         6087     8039    +1952     
- Misses       2949     3032      +83     
  Partials      738      738              
Flag Coverage Δ
api-test 62.27% <ø> (ø)
sdk-test-3.10 95.92% <ø> (?)
sdk-test-3.8 95.92% <ø> (?)
sdk-test-3.9 95.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Chore changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants